BuildForSDG / Phenom-Frontend

Team-056 frontent solution for BuildForSDG 2020 Innovation challenge.
MIT License
0 stars 5 forks source link

feat: updated the template to react #7

Closed onyijne closed 4 years ago

onyijne commented 4 years ago

BREAKING CHANGE: removed parcel as it wasn't working with ionic

Description

using just react parcel was okay, but on adding ionic it wasn't working, so I had to install react-scripts as it's compatible with ionic.

Fixes #2

How Has This Been Tested?

The previous test had node set as it's testEnvironment, I have updated this to jsdom which allowed the tests to go through.

Checklist:

onyijne commented 4 years ago

Codacy has 19 issues with the quality of src/themes/ionic.mixins.scss

Okay I'll take a look and make commits this evening.

onyijne commented 4 years ago

What state management system are we using, react or redux? What api library are we using, fetch or axios? If we are using third party, then we may need to install d packages or include their entries in package.json file

I have added axios, we will use react for state management. You can review again.

prominded commented 4 years ago

Very well then