BuildOnViction / bug-reports

TomoChain's Bug Report & Support
https://tomochain.com
17 stars 5 forks source link

"Infinity" amount in Buy Order #122

Open CryptoChaser13 opened 4 years ago

CryptoChaser13 commented 4 years ago

Hello. I tried to put a buy order and put 0.0000000 on price, as i clicked on 25% , 50% , 75% and 100% , amount in Buy order equates to Infinity which must not exist in the dex if im not mistaken. Is this normal? What i expect is that there must be no any inputs on amount if price is 0, or it must show invalid price because infinity is still a number yet very big.

INFINITY

thanhvk commented 4 years ago

At commit https://github.com/tomochain/tomox-sdk-ui/commit/6142d0082d85dd32f17fbddd8832e6c7f127d57f and https://github.com/tomochain/tomox-sdk-ui/commit/a33f068c8d0a2a63be463a0803b938c39ed92297 the issue already resolved you can see video below: https://drive.google.com/file/d/1H-B295YFaoZXUwA6tvAIoSy5ufBPbUZQ/view?usp=sharing

CryptoChaser13 commented 4 years ago

Why is it still encountered on chrome browser?

thanhvk commented 4 years ago

@MirasolFerrer it only already on the devnet.

CryptoChaser13 commented 4 years ago

Hello @thanhvk @thanhson1085 I have seen the video. The wallet isn't unlocked. May i request you to use an unlocked wallet. Put 0.0000000 on price and click on percentage. For sure it will output Infinity.

CryptoChaser13 commented 4 years ago

Screenshot_20200202-193315_Drive

thanhvk commented 4 years ago

I checked again with the wallet unlocked, this is a bug thanks @MirasolFerrer

CryptoChaser13 commented 4 years ago

Thank you sir @thanhvk

Here is my Tomo wallet address: 0xafb82d9c2609ead9534774b16f9d1377d2decea3

thanhson1085 commented 4 years ago

Confirmed with LOW severity @victorngn

CryptoChaser13 commented 4 years ago

May i have an update regarding the rewards for February bugs? It's first working day of March. Thanks. :) @chinhnt23 @victorngn