search

BuildOnViction / bug-reports

TomoChain's Bug Report & Support
https://tomochain.com
17 stars 5 forks source link

"Uncaught (in promise) Invariant Violation" #128

Closed CryptoChaser13 closed 4 years ago

CryptoChaser13 commented 4 years ago

I tried to apply a logo to my relayer. As i pasted the link of the photo, the page became blank and as i checked on console, It shows "Uncaught (in promise) Invariant Violation" with a red colored font. I also clicked the link it provided and it shown me: Objects are not valid as a React child (found: object with keys {code, message, detail}). Is this normal?

The image link i pasted is tomochain picture.

ERROR LOGO

error two

thanhson1085 commented 4 years ago

It is not normal, what link did you use? did you resign your relayer? How to reproduce it?

CryptoChaser13 commented 4 years ago

I did not resign my relayer. But i copied the link address of any image in google (selecing tomochain logo), pasted it to the relayer photo url, submitted it and got the blank screen. Upon clicking Inspect Element, i have got the errors.

My expectation is that, if the photo link isn't allowed, it must pop-up a "Invalid Photo Url" rather than a blank screen which make me reload the relayer and reopen again.

CryptoChaser13 commented 4 years ago

This is a follow-upof the issue i encountered. I tried using a different photo today, which is the link used in the page itself. You can watch the error here which supports my encounter:

https://youtu.be/2MS8jissxGs

thanhson1085 commented 4 years ago

You input wrong image url, the url have to start with 'http' or 'https'. TomoRelayer do not validate the inputs, we created the issue here. https://github.com/tomochain/tomorelayer/issues/73

CryptoChaser13 commented 4 years ago

Sir. I think i have included that in my expectation here: https://github.com/tomochain/bug-reports/issues/128#issuecomment-583788353

My expectation is that, if the photo link isn't allowed, it must pop-up a "Invalid Photo Url" rather than a blank screen which make me reload the relayer and reopen again.

That should have cleared the issue which Relayer must do a validation.

thanhson1085 commented 4 years ago

If there is validation, you can not submit a wrong link. Then you will not meed the blank page.

CryptoChaser13 commented 4 years ago

And that's what i expect instead of a blank page , at least "Invalid Photo Url" or "Link not Allowed"

thanhson1085 commented 4 years ago

I understand. So it is duplicated issue https://github.com/tomochain/tomorelayer/issues/73

CryptoChaser13 commented 4 years ago

Okay. Thanks @thanhson1085