Screen issue - Githubissues

BuildOnViction / bug-reports

TomoChain's Bug Report & Support

https://tomochain.com

17 stars 5 forks source link

Screen issue #148

Closed CryptoChaser13 closed 4 years ago

CryptoChaser13 commented 4 years ago

Hello. I encountered this issue :

Steps to reproduce:

Open dex with dark mode
On chart, Click Chart Properties button
Enable Light Mode
Close Chart Properties table

CryptoChaser13 commented 4 years ago

I also did reversely:

Steps to reproduce:

Open dex with light mode
On chart, Click Chart Properties button
Enable Dark Mode
Close Chart Properties table

CryptoChaser13 commented 4 years ago

Hello sir @thanhson1085 @thanhvk is this reproducible at your side?

thanhson1085 commented 4 years ago

I can reproduce it. But It is too minor to be considered as an issue. It also a small bug of Tradingview library, not from TomoDEX

CryptoChaser13 commented 4 years ago

Oh, meaning to say Tradingview is not part of the dex. So many closed issues now i guess sir, it seems you dont accept bugs anymore but rather just receive and compile it, label it closed, but still fix it. Sorry for saying this sir, but its just my sentiment. We are just here to help find any bugs on tomodex.

thanhson1085 commented 4 years ago

"label it closed, but still fix it", let me know the details, which "closed" issue was fixed? Feel free to drop a comment to the issue to have more discussion.

CryptoChaser13 commented 4 years ago

Its just my sentiment which is not impossible to happen sir. Anyways, i would want to compare this issue like this was confirmed and i checked was resolved. Please check https://github.com/tomochain/bug-reports/issues/72#issue-553488894 which was confirmed as low bug, and is now fixed. Seems similar, but mysubmitted issue still exists unlike the other one fixed already.

thanhson1085 commented 4 years ago

See this issue: https://github.com/tomochain/bug-reports/issues/75, we did not accept this bug. From your view, this bug is same as https://github.com/tomochain/bug-reports/issues/72#issue-553488894 But from developer view, we see the differences:

It has to open "setting", "switch light mode", "cancel setting" to reproduce the issue. It makes the severity of the issue is to minor to be considered as an issue.
The chart is using Tranding View iframe, we can not fix this bug if Trading view does not fix it.

thanhson1085 commented 4 years ago

We also did not accept this bug: https://github.com/tomochain/bug-reports/issues/73

CryptoChaser13 commented 4 years ago

Okay sir 😇