BuildOnViction / bug-reports

TomoChain's Bug Report & Support
https://tomochain.com
17 stars 5 forks source link

Some Inconsistency on Market Order #177

Open CryptoChaser13 opened 4 years ago

CryptoChaser13 commented 4 years ago

Hello. Ive seen some inconsistency on the dex' market order. You can see on the video, i have executed a market buy order under tomo/usdt pair , the order was rejected but the balance was deducted, making it transferred to my tomo balance. Now i try to execute a market sell to fill up again the usdt balance, so it was successfully executed. Now i try again to execute a market buy order, was again rejected but balance was deducted and transferred to my tomo balance. The video also indicates the notification of the rejection of the order.

https://youtu.be/-wLB-gZ7a8s

thanhson1085 commented 4 years ago

It is NOT an issue. Your market order will be rejected at this case: You place a SELL market order, it matched with 2 BUY orders. The first one is 9.5 TOMO, the second one is 0.5 TOMO. Then your market order will be filled 9.5 TOMO, and have rejected status.

thanhson1085 commented 4 years ago

I discussed with team about this scenario.

We will improve this flow. We will not return "rejected" order this case, it seems make user confusing. Thank you for the report.

CryptoChaser13 commented 4 years ago

That's what im claiming, why it posts Rejection yet the balance was deducted sir.

thanhson1085 commented 4 years ago

Confirmed for reward @chinhnt23 @victorngn

CryptoChaser13 commented 4 years ago

Thanks sir @thanhson1085 by the way here is my tomo address:

0xafb82d9c2609ead9534774b16f9d1377d2decea3

victorngn commented 4 years ago

Noted that @MirasolFerrer, your reward will be sent on the first working day of April. Thanks

victorngn commented 4 years ago

Reward sent @MirasolFerrer