BuildOnViction / tomox-sdk

SDK to build a Decentralized Exchange on TomoX protocol
MIT License
36 stars 18 forks source link

Missing some apis for orders, trades, terms for lending apis #126

Closed thanhvk closed 4 years ago

thanhvk commented 4 years ago
thanhvk commented 4 years ago

/trades/history need to change from requiring term and lendingToken to optional.

thanhson1085 commented 4 years ago

I have fixed it devnet.

thanhvk commented 4 years ago

we need to fix it

thanhvk commented 4 years ago
  1. The lending_trades websocket return empty tradeID in case type is UPDATE (type `INIT is ok) as below:

lending_trades_empty_tradeID

  1. The /terms api return duplicate data as below:

lending_terms_wrong_response

Expect: [60, 86400, 604800, 2592000]

thanhson1085 commented 4 years ago

I have fixed websocket tradeid, thank you for the report

thanhson1085 commented 4 years ago

Can we close this issue @thanhvk ?