issues
search
BuildOnViction
/
victionchain
The Efficient Blockchain Powered By Proof Of Stake Voting Consensus
https://viction.xyz
GNU Lesser General Public License v3.0
168
stars
85
forks
source link
Fix & Update EstimateGas API
#462
Open
c98tristan
opened
1 month ago
c98tristan
commented
1 month ago
Fix too many arguments, want at most 1 when call
eth_estimateGas
Fix default
gasPrice
depend on
balanceTokenFee
Add
executionResult
to emphasizes the difference between Consensus error and EVM internal error.
Fix race condition by copy state from
stateDB
each execution.
Optimize time execution estimate gas.
Get
balanceTokenFee
from
stateDB
instead of default value
Remove
gasLimit
and
gasPrice
when using contract call
Remove logic set gasPrice when balanceTokenFee exist.
Unit testing
Reference:
https://github.com/ethereum/go-ethereum/pull/18445
https://github.com/ethereum/go-ethereum/pull/20261
https://github.com/ethereum/go-ethereum/pull/20702
https://github.com/ethereum/go-ethereum/pull/20783
https://github.com/ethereum/go-ethereum/pull/20830
https://github.com/ethereum/go-ethereum/pull/21043
https://github.com/ethereum/go-ethereum/pull/21083
https://github.com/ethereum/go-ethereum/pull/21346
https://github.com/ethereum/go-ethereum/pull/21545
https://github.com/ethereum/go-ethereum/pull/21601
https://github.com/ethereum/go-ethereum/pull/24363
https://github.com/ethereum/go-ethereum/pull/27505
https://github.com/ethereum/go-ethereum/pull/27710
imterryyy
commented
1 month ago
Does this change require protocol update ?
beage666
commented
1 month ago
Yes
Reference: