BuildTheEarth / bte-net-issues

Tracker for buildtheearth.net issues
5 stars 0 forks source link

Minefact Staff appearing in Tab list in Build Team Servers. #25

Open ElectroYT2003 opened 3 years ago

ElectroYT2003 commented 3 years ago

Describe the bug When a member of Minefact's staff joins a build team server (Architect, Supporter, Developer, etc.). They appear as having that role when you press tab, despite them not being that role on that specific team, and in most cases, not even being in that team's discord. This has been asked to be solved many times before, yet solutions seem to be half-assed and done to 'solve the issue' without actually solving the issue.

Allowing build teams to add roles to people on their servers does not solve this, the matter of the fact is that having random people who have nothing to do with the build team, have a staff role when they join the server, creates confusion and can (in some cases) ruin the aesthetic (like in build teams where they are attempting to not have any roles when you press tab.

Now, since it has been asked many times, and has been approved many times (with 'solutions' that do not actually solve the issue), I am going to consider this a bug, since apparently it has been 'fixed' several times already. Thank you!

To Reproduce

  1. Join a build team server that has a Minefact staff member online.
  2. Press tab

Expected behavior Not have random people who are not builders on said build team have a form of Staff role (Such as architect, supporter etc.)

Screenshots image

Minecraft Version:

Additional context It has been asked for this to be fixed many times, and it was said that there was a solution (build tams could add their own roles to people), but that still doesnt solve the initial issue that Mine fact architects are appearing as architects on Build team Servers.

Nudelsuppe42 commented 3 years ago

Does your server has a custom tablist?

Coppertine commented 3 years ago

local custom tablists are overriden by the proxy tablist, so there's no reason why it would be fixed with just the local server

ElectroYT2003 commented 3 years ago

local custom tablists are overriden by the proxy tablist, so there's no reason why it would be fixed with just the local server

^

Does your server has a custom tablist?

Yes, but I don't see why that matters since it is over-written by the Proxy tablist. The issue is precisely that this is something proxy-side which we cannot change, which, I believe (and according to feedback, others also believe), should be changed such that only members who are given that role by the build team, should have that role in the tablist when joining a Build team server. Otherwise, we are just getting randos who we dont even know who they are, and suddenly they are 'Supporters' or 'Architects' while the people in our that who are actually builders, support, devs etc. for that specific server dont get those roles (My goal in my build team is to have nobody have any roles, Owners, Moderators, Builders, Members.. Everyone is green with no prefix.. and this 'bug' that has been "fixed" several times now, ruins that aesthetic that I am trying to achieve.)

If you look at resolved issues (on this GitHub), you will notice that Minefact actually responded to an old suggestion saying that "With the BuildTeam plugin which is currently in development we will probably also add a permission system for each build team and then we can remove the staff prefix in the tab list." (back in december of 2020)

Then moved it to the 'Resolved issues' tab, without actually resolving it!

ElectroYT2003 commented 3 years ago

This issue was 50% fixed at one point (where it would no longer put Staff | (Name) for people in other servers (but would still put the person's prefix in servers where they didnt have any staff role (like Enli being Support when joining the Iberia server, for example. Or Mr Snow/Grayderp/Scottie (and countless other architects) having architect when Joining Iberia)).

Though the 50% fix went back to a 0% fix now, and it once again shows the Staff | Prefix everywhere.