search

BuilderIO / builder

Visual Development for React, Vue, Svelte, Qwik, and more
https://builder.io
MIT License
7.58k stars 950 forks source link

Upgrade isolated-vm version to latest version #2963

Open hassanzohdy opened 10 months ago

hassanzohdy commented 10 months ago

Describe the bug The package isolated-vm version 4.6 breaks in Windows 10 because there was an error in some file, while latest version of isolated-vm works fine, this happens when i try to install Qwik development server, it does not complete the setup because of this error.

This happens only with that version, but newer versions of isolated-vm works fine in Windows 10.

So if there is no particular reason not to update the package to the latest version, please update it.

Thank you.

samijaber commented 10 months ago

We will investigate. Can you share an exact version number that works on Windows 10?

In the meantime, you can override the version and select a higher one that works for you using something like yarn resolutions or pnpm overrides

hassanzohdy commented 10 months ago

Thanks for the hint, current working version is 4.7.2.

gskaushal92 commented 7 months ago

@samijaber I am also getting the same issue. Is there any update on this? image

I am using latest version of @builder.io/sdk-svelte@1.0.15.

Is there any workaround to fix this issue?

gskaushal92 commented 7 months ago

I have tried by Overriding isolated-vm version to 4.7.2. But I am still getting the same issue.

samijaber commented 7 months ago

@gskaushal92 The isolated-vm library used by the SDK requires node-gyp to be installed. I am unfamiliar with Windows, but it seems that for some reason, in your case you need to manually install it in the case of Windows: