Closed harmeet-builder closed 1 year ago
Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
one other piece of feedback - this is a lot of text and the warning is pretty intense. maybe we should only show the warning text after you click "get code"? feels like we want from too friendly (no heads up) to too scary (wall of text and big bold "WARNING!") and feels like there is a happy middleground somewhere
open to other ideas to strike this balance. but the warning may be better as a "while you wait, be aware that this is not magic ..."
one other piece of feedback - this is a lot of text and the warning is pretty intense. maybe we should only show the warning text after you click "get code"? feels like we want from too friendly (no heads up) to too scary (wall of text and big bold "WARNING!") and feels like there is a happy middleground somewhere
@steve8708 the warning can also appear on the Visual Editor side of things, in a popup modal on-load. That would defer it and keep this plugin un-cluttered
@steve8708, @samijaber. Removed the word Warning and simplified the text. Also created task of pop-up modal on load in builder editor
Following changes are done to plugin UI
Screenshots