Closed guillermoscript closed 7 months ago
Preparing review...
Preparing review...
Preparing review...
Very cool @guillermoscript! We just have a merge conflict and once resolved we can get this in
thanks! I just updated the code, basically just adding the sitemap support to this new version and the block resouce list prop, so users can skip images for example, if you want to test those I would recommend you to use
let me know if any other change is required :D
looks great, just a couple new merge conflicts then we're good to go
looks great, just a couple new merge conflicts then we're good to go
conflict resolved 👍
:tada: This PR is included in version 1.0.0 :tada:
The release is available on:
Your semantic-release bot :package::rocket:
This pull request includes several changes to improve the functionality of the code:
Refactored the
getPageHtml
function to handle the case when the specified selector is not found on the page. In this case, the function now falls back to using thebody
selector to retrieve the page content.Added a try-catch block to handle the case when the specified selector is not found during the page crawl. If the selector is not found, a warning message is logged and the function falls back to using the
body
selector.Added support for downloading URLs from a sitemap.xml file. If the provided URL is a sitemap, all pages listed in the sitemap will be crawled.
Updated comments in the code to indicate that sitemap support has been added.
These changes improve the robustness and flexibility of the code, allowing it to handle cases where the specified selector is not found and enabling the crawling of pages listed in a sitemap.
Fixes #16