search

BuilderIO / gpt-crawler

Crawl a site to generate knowledge files to create your own custom GPT from a URL
https://www.builder.io/blog/custom-gpt
ISC License
18.59k stars 1.97k forks source link

chore: add prettier check #88

Closed kunal00000 closed 10 months ago

kunal00000 commented 10 months ago

This PR is copy of #48 . It got messed up while rebasing.

Resolves #47

marcelovicentegc commented 10 months ago

Nice, @kunal00000! It looks like the test workflow is broken, you might need to run npm run fmt first (https://github.com/BuilderIO/gpt-crawler/pull/88/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519R37)

kunal00000 commented 10 months ago

Umm 🤔, does this workflow need to have fmt command to fix prettier issues. I thought it was to just check and not edit code by fixing prettier errors.

marcelovicentegc commented 10 months ago

I woul

Umm 🤔, does this workflow need to have fmt command to fix prettier issues. I thought it was to just check and not edit code by fixing prettier errors.

Sorry I might not have been clear! The workflow doesn't need to format any code, this step should be done on a pre-commit hook IMO (another PR). What I mean is that the prettier check is failing, so you need to run npm run fmt yourself to format the code and once you commit these formatting changes the pipeline will pass 🤗

kunal00000 commented 10 months ago

Ah got it. How do I do it using pre-commit hook never used it before.

github-actions[bot] commented 10 months ago

:tada: This PR is included in version 1.1.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: