feat: Spotlight integration with hydration-overlay

BuilderIO / hydration-overlay

Overlay for hydration errors with explicit diff between renders.

MIT License

500 stars 17 forks source link

Closed Shubhdeep12 closed 4 months ago

Shubhdeep12 commented 10 months ago

Feature Addition: Spotlight Integration in Hydration-Overlay

This pull request introduces an integration of Spotlight into the hydration-overlay module.

Key Highlights:

Addressed all necessary conditions outlined in the discussion here.
Note: Current integration and tests may not function as expected due to pending integration support in Spotlight. The implementation is primed for action once the necessary changes are merged.

Next Steps:

Track the progress of Hydration-overlay integration in Spotlight here.
Upon completion of Spotlight integration, a simple version update for the Spotlight package in this repository is all that's needed.

changeset-bot[bot] commented 10 months ago

Latest commit: f199813801ec31e0aae34d7e6fd469cc2b0076ca

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

| Name | Type | | ----------------------------------- | ----- | | @builder.io/react-hydration-overlay | Minor |

Shubhdeep12 commented 10 months ago

Hi @samijaber, we are done here. we published a new version in spotlight to support hydration-overlay. Added a test case also for nextjs app.

Please review.

Thanks.

btw, I found a issue while setting up webpack in nextjs with hydation-overlay but that will not hamper anything here. I'll open it seperately.

Shubhdeep12 commented 6 months ago

Hi @samijaber just bumping here as a reminder for this PR. Thanks