search

BuilderIO / partytown

Relocate resource intensive third-party scripts off of the main thread and into a web worker. 🎉
https://partytown.builder.io
MIT License
12.97k stars 427 forks source link

Intercom example works only on Chrome #278

Open bmstefanski opened 1 year ago

bmstefanski commented 1 year ago

Describe the bug The intercom example doesn't seem to work on Safari Desktop & Mobile, or Firefox. It works on Chrome though.

To Reproduce Steps to reproduce the behavior:

  1. Go to https://partytown.builder.io/tests/integrations/intercom/
  2. See if the Intercom widget pops up

Reproduction link https://partytown.builder.io/tests/integrations/intercom/

Expected behavior Ideally, it should work on all modern browsers or throw an error with some descriptive message if it's due to the lack of a support for some feature

Partytown version Not sure, the source code is located in the official repository, here

Additional context The official example was not working at all, even on Chrome a few months ago. Now only Chrome seems to work.

Firefox logs:

image

Safari logs:

image

Thanks in advance for the response and an amazing library. Let me know if more details are needed :)

public-hosting commented 1 year ago

Unfortunately currently it does not work even in Chrome

frame-modern.5069da72.js:2141 Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'map')
    at me (frame-modern.5069da72.js:2141:55)
    at async eval (frame-modern.5069da72.js:10014:19)
maplessmann commented 1 year ago

We are having a similar issue. The Intercom widget works, but if a user clicks on a message the widget disappears and Partytown throws this error:

TypeError: Cannot set property scrollTop of [object Object] which has only a getter
    at p (frame-modern.11044599.js:3:115138)
    at conversation_body_ConversationBody.scrollToBottom (app-modern.781a032c.js:6:175909)
    at conversation_body_ConversationBody.componentDidUpdate (app-modern.781a032c.js:6:177449)
    at as (vendors~app~tooltips-modern.41236692.js:4:129869)
    at gl (vendors~app~tooltips-modern.41236692.js:4:147472)
    at i.unstable_runWithPriority (vendors~app~tooltips-modern.41236692.js:4:167679)
    at Qo (vendors~app~tooltips-modern.41236692.js:4:91490)
    at Tl (vendors~app~tooltips-modern.41236692.js:4:144138)
    at sl (vendors~app~tooltips-modern.41236692.js:4:140292)
    at eval (vendors~app~tooltips-modern.41236692.js:4:91781)

@adamdbradley do you know this error?

lsimone commented 1 year ago

The example does not work in Chrome either.

Is there any chance this 5 months ago issue will be taken into account?

image