search

Builderb0y / BigGlobe

This is my worldgen mod for Minecraft. There are many like it, but this one is mine.
Other
43 stars 1 forks source link

Doesn't work with dynamic surroundings #16

Open Drfreeman1488 opened 1 week ago

Drfreeman1488 commented 1 week ago

Whenever I enter any biome, the ambient sounds don't play at all. Only sounds like toolbar switching or reverb, other than a few other sounds, the world is incredibly dead. I think this is due to the mod not recognizing big globe biomes.

Builderb0y commented 1 week ago

That is probably why, yeah. DS looks like it can be configured to detect modded biomes, and it might be possible to have compatibility built-in to big globe. But it also says the current format is unstable and un-documented. Maybe I'll make a compatibility addon for it eventually, assuming no one else makes one first.

Drfreeman1488 commented 1 week ago

I would appreciate it if you did make a patch for it. I'm going to see if I can add the biomes to the JSON by myself and see if it works

Drfreeman1488 commented 1 week ago

I tried adding them through the JSON and it didn't work, no sounds as usual

trewqaGGG commented 1 week ago

Oof, your problem resolves soon. I use ambientsounds instead of Dynamic Surroundings

Drfreeman1488 commented 1 week ago

If it helps, putting the biome names inside the mods file did not work, perhaps something in the parentheses could work but there are a lot of moving parts in this mod. image_2024-09-28_171946250

Builderb0y commented 1 week ago

I doubt that's valid syntax to have two &&'s next to each other like that. And also a biome can't simultaneously be two other biomes, so that should probably use || instead of &&.

Drfreeman1488 commented 1 week ago

I doubt that's valid syntax to have two &&'s next to each other like that. And also a biome can't simultaneously be two other biomes, so that should probably use || instead of &&.

Aah, I apologize, but I haven't done a lot of coding in my life

Builderb0y commented 1 week ago

Dynamic Surroundings claims to use Nashorn's JS engine, so if you can learn a little bit of JS syntax, it would probably help for adding compatibility.