Builderb0y / BigGlobe

This is my worldgen mod for Minecraft. There are many like it, but this one is mine.
Other
13 stars 0 forks source link

Nether biomes set fog color for shaders to white #9

Open IceBlossom opened 3 months ago

IceBlossom commented 3 months ago

Problem: When in a Nether biome with shaders enabled (personally only tested with Complementary 5.1.1 + Euphoria Patches 1.2), the fog color is set to white, resulting in the area looking like purgatory.

How to reproduce:

Screenshots: 2024-05-15_12 54 55 2024-05-15_13 15 54 2024-05-15_13 17 32

This issue does not happen in The End nor in the Overworld, as far as I can tell. I don't know about the Hyperspace dimension, as I do not know how to get there.

Builderb0y commented 3 months ago

I can't seem to reproduce this issue with any shader pack I tried, including euphoria patches on default settings. I also tried the reimagined and unbound profiles, and all 3 of the nether color modes, since those can influence the fog color. Fog color depends on the biome, and Big Globe does specify colors for all of its biomes.

Last time I checked, shader packs can't detect when the player is in a modded biome due to limitations in iris (but they CAN detect the fog color of the biome that the player is currently in), and both complementary and euphoria do have some code to detect when the player is in a nether biome, but this code also has a fallback for when the player is in an unrecognized nether biome, and this fallback seems to be working as intended. At least for me.

This issue might be related to your shader settings if you've tweaked them, or another mod might be interfering with how shaders work. You can try resetting your shader settings (make a backup of them first), or testing without any other mods besides Sodium and Iris.

Btw, you didn't ask, but that purple and black block in the last screenshot is a technical block which assists with tree generation. It's supposed to disappear before you get a chance to see it, but sometimes this fails. It might vanish if you place another block nearby or press F3 + A.

As for how to enter hyperspace, you need to craft a waypoint for that, using ender pearls and bottled aura. Bottled aura can be obtained by right clicking an aura-infused cloud or void cloud with an empty bottle. Clouds can be found in skylands over the ocean, and void clouds can be found in the end dimension. You can also find bottled aura in the chests in end cities.

Builderb0y commented 3 months ago

Small update: managed to reproduce this issue in the ashen wastes and inferno biomes with nightvision applied. Both of these biomes are supposed to have a dark gray fog color, but nightvision makes this a very bright gray color instead, and I guess euphoria patches makes it even brighter. This is not something I directly control, though I do also wish that nightvision wouldn't mess with my fog colors.

Fog color is purple as intended in the warped forest biome for me, so I'm not sure why that one is white for you. See previous comment I guess.

Builderb0y commented 3 months ago

Have you had any luck figuring out what shader settings or other mods might be causing this yet?

IceBlossom commented 3 months ago

Decided to finally do some more testing after I recieved this message. And I noticed something peculiar, it's in the video here

EDIT: apparently my video recording never stopped!!!! will make a new video, hold on

IceBlossom commented 3 months ago

https://github.com/Builderb0y/BigGlobe/assets/78196119/a3bc8b3f-9563-40ab-9d31-26b782d145db

Builderb0y commented 3 months ago

In that case, I'm gonna blame this line of code in sodium extra, as I can confirm that setting the "single fog" setting to "off" changes the fog color that shaders see. For what it's worth, this option seems to set the fog color to white in the overworld and end too.