search

BuildforSDG-Cohort1-Assessment / covid-19-estimator-js

An overly simplified COVID-19 infections impact estimator
MIT License
23 stars 68 forks source link

Need for an eslint line break rule. #10

Open vickywane opened 4 years ago

vickywane commented 4 years ago

Considering those who would be attempting this challenge using a non unix Operating Sytems, i think "linebreak-style": 0 should be added to the current.eslintrc rules as it causes a Expected linebreaks to be 'LF' but found 'CRLF' error and it is also being run in the checks.

More details on this at https://stackoverflow.com/questions/37826449/expected-linebreaks-to-be-lf-but-found-crlf-linebreak-style

Iamnonso commented 4 years ago

I think any lead developer should know that.

Iamnonso commented 4 years ago

All documentation can be found in eslint website https://eslint.org/docs/

Murphite commented 4 years ago

Thanks for the prompt messages.

But seriously i don't know where to start from here in the setup. I tried yesterday even through today, I've yet not been able. Kindly help me out, thanks.

On Sat, Apr 11, 2020, 2:31 PM Madugba Emmanuel Chinonso < notifications@github.com> wrote:

All documentation can be found in eslint website https://eslint.org/docs/

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/BuildforSDG-Cohort1-Assessment/covid-19-estimator-js/issues/10#issuecomment-612421983, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOYXAFCOHSZGQN3TGA3D74DRMBWMDANCNFSM4MFD5YXQ .

vickywane commented 4 years ago

I think any lead developer should know that.

I do not get the underlying meaning of your statement.

However this could be an omission considering it's an OS specific lint error; You wont get it when using a unix environment.