BuildingSync / BuildingSync-website

5 stars 0 forks source link

feat: add data dictionary json for enumerations list #96

Closed macintoshpie closed 3 years ago

macintoshpie commented 3 years ago

background

BSync is redesigning its website, merging the old site and selection tool

changes

This PR adds an enumerations_file field to the schema model. This field is intended to store the enumerations.json produced by the schema repo (see here)

This PR adds the /enumerations/x.x.x/ page for viewing terms. Note this does not add the same page for listing Measures. That will be handled separately. Also the styling could be improved (lines between rows, bullets in enumerations list) but I will do that later.

testing

Upload an enumerations json file generated by bsync repo for some schema file from the admin page. Then navigate to the enumerations page for that version and you should be able to view all of them and filter with the search bar.

screenshots

Screen Shot 2021-05-27 at 3 56 28 PM
coveralls commented 3 years ago

Pull Request Test Coverage Report for Build 896749967


Changes Missing Coverage Covered Lines Changed/Added Lines %
bsyncviewer/models/schema.py 3 8 37.5%
bsyncviewer/views.py 1 15 6.67%
<!-- Total: 9 28 32.14% -->
Files with Coverage Reduction New Missed Lines %
.tox/python/lib/python3.6/site-packages/urllib3/packages/ssl_match_hostname/init.py 4 45.45%
.tox/python/lib/python3.6/site-packages/urllib3/util/url.py 12 24.38%
.tox/python/lib/python3.6/site-packages/urllib3/util/ssl_.py 93 23.96%
.tox/python/lib/python3.6/site-packages/urllib3/packages/six.py 151 51.49%
<!-- Total: 260 -->
Totals Coverage Status
Change from base Build 829566785: -0.01%
Covered Lines: 36743
Relevant Lines: 84180

💛 - Coveralls