BuildingSync / TestSuite

Other
3 stars 1 forks source link

Do we need auc:Capacity for HeatingPlant types? #31

Closed macintoshpie closed 3 years ago

macintoshpie commented 4 years ago

Context

STD 211 6.2.1.3.a requires System design capacity (kW, Btu/h, and/or tons) for HVAC systems. In BuildingSync, CoolingPlants (e.g. auc:Chiller and auc:DistrictChilledWater) have child elements auc:Capacity (same for auc:Delivery, and auc:CoolingSource.

However, auc:HeatingPlant types (as well as auc:HeatingSource) have auc:InputCapacity and auc:OutputCapacity.

Task

Why does auc:HeatingPlant and auc:HeatingSource have these different capacity elements? Should they also include auc:Capacity?

nllong commented 4 years ago

I think that this is why we have input and output capacity. image This is from ASHRAE. (2020). ASHRAE Handbook - HVAC Systems and Equipment. American Society of Heating, Refrigerating and Air Conditioning Engineers.

So I suggest the following. Let's deprecate the term OutputCapacity (flag it) and add in Capacity. Make sure that the Capacity definition is the output capacity (which it should be). Then in version 3.0, we remove OutputCapacity. Keep InputCapacity as is for now.

macintoshpie commented 4 years ago

Just to confirm, do we want to make this change for all of these cases?

nllong commented 4 years ago

yes, change OutputCapacity to Capacity in all of those cases.

macintoshpie commented 3 years ago

Addressed here: 6d3a4d93335fd7e9b3c16afa7d52a2a56d79cdad