search

BuildingSync / schema

BuildingSync® Schema
https://buildingsync.net
Other
23 stars 22 forks source link

Deprecate WallID as direct child under Side #345

Closed JieXiong9119 closed 3 years ago

JieXiong9119 commented 3 years ago

See proposal.

Resolves #233

nllong commented 3 years ago

@JieXiong9119 Are you planning on updating the examples so these tests will pass? Or are we waiting for @macintoshpie 's translator?

JieXiong9119 commented 3 years ago

@JieXiong9119 Are you planning on updating the examples so these tests will pass? Or are we waiting for @macintoshpie 's translator?

I'll probably update the examples first.

macintoshpie commented 3 years ago

@JieXiong9119 can you resolve these conflicts? Once that's done we should be good to merge

JieXiong9119 commented 3 years ago

@JieXiong9119 can you resolve these conflicts? Once that's done we should be good to merge

Just did. Could you check one more time and merge it if it looks good?