search

BuildingSync / schema

BuildingSync® Schema
https://buildingsync.net
Other
23 stars 22 forks source link

Deprecate PrimaryHVACSystemType #352

Closed JieXiong9119 closed 3 years ago

JieXiong9119 commented 3 years ago

See proposal.

Resolves #230

macintoshpie commented 3 years ago

@JieXiong9119 maybe we could add a transformation to the xslt for making this conversion?

nllong commented 3 years ago

I don't think we need an XSLT on this one since we have warned that we are deprecating. Feel free to disagree, but I think we can merge this one for now.

macintoshpie commented 3 years ago

I don't think we need an XSLT on this one since we have warned that we are deprecating. Feel free to disagree, but I think we can merge this one for now.

I think we still might want to include it in xslt, but I agree let's merge it

JieXiong9119 commented 3 years ago

I don't think we need an XSLT on this one since we have warned that we are deprecating. Feel free to disagree, but I think we can merge this one for now.

I have included this change in the updated XSLT in this PR #360 simply by renaming it to the correct one. I think it's better to have all "breaking changes" covered by the XSLT.