search

BuildingSync / schema

BuildingSync® Schema
https://buildingsync.net
Other
23 stars 22 forks source link

Rename reference element #423

Closed JieXiong9119 closed 2 years ago

JieXiong9119 commented 2 years ago

Any background context you want to provide?

See proposal.

What does this PR do?

  1. Rename IDREF element as suggested in #415 : AlternativeSystemAdded -> AlternativeSystemIDAdded AlternativeSystemReplacement -> AlternativeSystemIDReplacement ExistingScheduleAffected -> ExistingScheduleIDAffected ExistingSystemAffected -> ExistingSystemIDAffected ExistingSystemRemoved -> ExistingSystemIDRemoved ExistingSystemReplaced -> ExistingSystemIDReplaced SourceHeatingPlantID -> HeatingPlantID LinkedHeatingPlantID -> HeatingPlantID DeliveryIDs -> LinkedDeliveryIDs DeliveryID -> LinkedDeliveryID MakeupAirSourceID -> MakeupAirSpaceID ModifiedSchedule -> ModifiedScheduleID ModifiedSystem -> ModifiedSystemID ReferenceCase -> ReferenceScenarioID

  2. Update the descriptions of the IDREF elements to include the valid reference paths as revealed in #415.

  3. Update the xslt translator to include the renaming changes.

  4. Update the examples.

What are the relevant tickets?

415

416

JieXiong9119 commented 2 years ago

This is awesome - so well documented! Great job! I just had a few questions, and also was wondering if you could add some of the v2 id's to our translator test files so we know the v2->v3 translator is working?

Yes I forgot to update that. Thanks for noticing!

JieXiong9119 commented 2 years ago

Lots of updates on the translators and test examples!