search

BuildingSync / schema

BuildingSync® Schema
https://buildingsync.net
Other
23 stars 22 forks source link

Remove xmlns and nX:source in example files #427

Closed nllong closed 2 years ago

nllong commented 2 years ago

The ASHRAE 211 export example file still has the xmlns and nX:source in the interval reading element. These should be removed to ease readability.

V3: https://github.com/BuildingSync/schema/blob/develop-v3/examples/ASHRAE%20211%20Export.xml#L1382-L1390 V2: https://github.com/BuildingSync/schema/blob/develop-v2/examples/ASHRAE%20211%20Export.xml#L1382-L1390

JieXiong9119 commented 2 years ago

The oldest PR/commit we could trace back where these redundant attributes exist is #48. It's still not clear yet how these were generated, but one guess is that they were generated at the beginning with the use of std211 translator. Given the fact that this translator is out of date for many versions of BuildingSync, I suggest we do not investigate into it until necessary.

nllong commented 2 years ago

The oldest PR/commit we could trace back where these redundant attributes exist is #48. It's still not clear yet how these were generated, but one guess is that they were generated at the beginning with the use of std211 translator. Given the fact that this translator is out of date for many versions of BuildingSync, I suggest we do not investigate into it until necessary.

agreed.