search

BuildingSync / schema

BuildingSync® Schema
https://buildingsync.net
Other
23 stars 22 forks source link

Update notebooks quotes #448

Closed JieXiong9119 closed 1 year ago

JieXiong9119 commented 1 year ago

Any background context you want to provide?

We recently update the notebook examples folder to have both level 1 and 2 audits for small office prototype building. This PR follows this up to clean up some left tails.

What does this PR do?

Update notebook examples to have consistent quote usage (double quotes), descriptive text and the outputs.

How should this be manually tested?

Convert the Small-Office-Level-1.md and Small-Office-Level-2.md into Jupyter Notebooks to edit and run to create xml outputs.

What are the relevant tickets?

https://github.com/BuildingSync/project-tracker/issues/121

JieXiong9119 commented 1 year ago

The validation result image for level 1 example was not updated. The added GHG elements were not updated on the BuildingSync website so the validator gave errors on those elements when validating "example-smalloffice-level1.xml".

JieXiong9119 commented 1 year ago

Hey Jie - saw that "isn't" was changed to "isn"t'. Don't think this was in more than one place, but I can also not view the Level 2 audit for some reason (diff isn't loading). Can you just make sure? Otherwise I think this looks great and is good to go! Thanks for your amazing work here and sorry for my long time in reviewing!

Good catch! I modified that and will merge it.