BuildingSync / schema

BuildingSync® Schema
https://buildingsync.net
Other
23 stars 22 forks source link

Add PrincipalLightingSystemType #473

Closed JieXiong9119 closed 1 year ago

JieXiong9119 commented 1 year ago

See proposal

Any background context you want to provide?

What does this PR do?

To add PrincipalLightingSystemType under Building and Section to enable direct mapping to/from Audit Template Tool, and omit the usage of UDF. However we do not recommend using this element other than AT use case, Instead, in BuildingSync world, we recommend using System/LightingSystems/LightingSystem/LampType to specify lighting type and link it to the correponding Building or Section via LightingSystem/LinkedPremises.

How should this be manually tested?

To do: need to confirm if the enumerations mapped correctly to AT library. To do: need to make sure the usage of referencing global element is correct. To do: test for schema and example validity.

What are the relevant tickets?

470

466

markborkum commented 1 year ago

@JieXiong9119, The range for the "Principal Lighting System Type" user-defined field:

Source: https://github.com/pnnl/assetscore-schematron-docs/blob/9ed7eb94e91a553d28cc9873058a0cc82fb9b8f2/docs/Audit_Template/New%20York%20City%20Energy%20Efficiency%20Report.xml#L3379-L3381

JieXiong9119 commented 1 year ago

@JieXiong9119, The range for the "Principal Lighting System Type" user-defined field:

  • Compact Fluorescent
  • Halogen
  • Incandescent
  • LED
  • Mercury Vapor
  • Metal Halide
  • Sodium Vapor High Pressure
  • T5
  • T5HO
  • T8
  • Super T8
  • T12
  • T12HO

Source: https://github.com/pnnl/assetscore-schematron-docs/blob/9ed7eb94e91a553d28cc9873058a0cc82fb9b8f2/docs/Audit_Template/New%20York%20City%20Energy%20Efficiency%20Report.xml#L3379-L3381

Thanks. Would we want to keep "Other" and "Unknown"?

markborkum commented 1 year ago

Would we want to keep "Other" and "Unknown"?

Including them would align with the definitions for other enumerations in the schema.

Another design question is whether to include all lighting system types that are present in the schema.