search

Builditluc / wiki-tui

A simple and easy to use Wikipedia Text User Interface
https://wiki-tui.net/
MIT License
405 stars 14 forks source link

[FEATURE] auto-language switching #165

Closed akito-sama closed 1 year ago

akito-sama commented 1 year ago

I am always frustrated when i cannot change a language in an app especially for non native english speaker, although there is a manual way to change the wiki link through the config file, i would like to see an automated system which let you choose the language of Wikipedia you want, and change the link in the config file instead of you .

thanks for considering this feature, i really like wiki-tui .

Builditluc commented 1 year ago

Hey @akito-sama, thank you for your feature request! You're right, we currently have no way of quickly changing the configured language of the articles! Because the toml file format which we use for configuration has many ways of representing the data (basically, you can write them differently in the file and it is interpreted the same for the program), we, unfortunately, cannot write data to the configuration file after it was created (it would ruin the file format).

Could a cli argument satisfy your needs? Something like this:

# change the language to german
wiki-tui github -l de 
wiki-tui github --language de

That way we can still change the language on the fly and we wouldn't ruin the custom format of the configuration file.

akito-sama commented 1 year ago

sure, this would be awesome, and if i may, i would suggest to also having a command to change the language in runtime too, if possible, this would make searching infos much easier, rather than closing and reopening the program . Thank you for considering theses ideas .

Builditluc commented 1 year ago

Yes, that would totally be possible and I agree that having the option to change these configs on the fly would make it much easier. What would you think about having a popup that lets you change the language that can be opened by pressing a certain key? Or would your rather like having a little "configure" button below the search bar?

akito-sama commented 1 year ago

i guess having a popup would be better than having a configure button in the entry points, it would make much more sense than having a configure button except if there would be more option than language to choose from, in that case i would suggest having both a popup for language and a configure button for the other option.

thank you soo much for your work on this project .

Builditluc commented 1 year ago

Great, I'll start implementing this feature as soon as possible! If you have any further suggestions, let me know!

Builditluc commented 1 year ago

Just letting you know that this feature will take a bit longer to implement because, with this, we (finally) can't use global variables anymore and have to pass the config down everywhere it's needed.