search

BuildmLearn / BuildmLearn-Toolkit-Android

This repository contains the Android version of the BuildmLearn Toolkit. BuildmLearn Toolkit is an easy-to-use program that helps the users make mobile apps without any knowledge of application development.
BSD 3-Clause "New" or "Revised" License
57 stars 132 forks source link

App is crashing #271

Closed jainkuniya closed 7 years ago

jainkuniya commented 7 years ago

videotogif_2016 12 12_14 21 19 In My Drafts page when we select one item (by long pressing) and then click on Select all in actionbar app crashes.

codingblazer commented 7 years ago

@vishwesh3 I can't replicate this problem. Can you tell the reason or logcat for this problem. I think you must have some old drafts and in any run from Android Studio data would have been removed causing crash on NullPointerException. (It has happened to me many times on other projects).If this is the case, it happens only on developer's device and no fix is required.

jainkuniya commented 7 years ago

@codingblazer Yes it was due to some old drafts, as soon as i reinstalled app it was solved. But the app is going to be published on play store soon so I think there should be null pointer check before getting child.

mListView.getChildAt(i)

waiting for @opticod review.

opticod commented 7 years ago

I too was unable to duplicate the issue. Closing it for now.

jainkuniya commented 7 years ago

I got some clue when app is crashing Steps to reproduce it If the list of draft is more ( list becomes scrollable ) e.g. if your screen can occupy 7 items and you have more than 10 drafts, on selecting all, it crashes.

videotogif_2016 12 15_16 51 59 videotogif_2016 12 15_16 48 10

@opticod please have a look on it.

opticod commented 7 years ago

@vishwesh3, thanks for it. Its crashing. Re-opened issue. Are you working on this?

jainkuniya commented 7 years ago

Yes I am working on it. Please review #300 so that my new commit doesn't go in that PR.

opticod commented 7 years ago

Work independently in different branches, will merge them independently.

jainkuniya commented 7 years ago

ok. I am almost done will soon create new PR in bug-fixes branch.

opticod commented 7 years ago

closed via #309