search

BuildmLearn / BuildmLearn-Toolkit-Android

This repository contains the Android version of the BuildmLearn Toolkit. BuildmLearn Toolkit is an easy-to-use program that helps the users make mobile apps without any knowledge of application development.
BSD 3-Clause "New" or "Revised" License
57 stars 132 forks source link

Fix #412: next button on first screen after installation #433

Closed DravitLochan closed 7 years ago

DravitLochan commented 7 years ago

I don't remember using snake case but I'll fix it right away. :)

On 25-Feb-2017 12:20 PM, "Codacy Bot" notifications@github.com wrote:

[image: Codacy] https://camo.githubusercontent.com/37ddd55708a38212f4e9de4e3eac98358fefe597/68747470733a2f2f7777772e636f646163792e636f6d2f6173736574732f696d616765732f66617669636f6e2e706e67 Here is an overview of what got changed by this pull request:

Issues ======- Added 1

Complexity increasing per file ==============================- source-code/app/src/main/java/org/buildmlearn/toolkit/activity/FirstRunActivity.java 6

See the complete overview on Codacy https://www.codacy.com/app/anupam/BuildmLearn-Toolkit-Android/pullRequest?prid=534176&bid=4234210

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/BuildmLearn/BuildmLearn-Toolkit-Android/pull/433#issuecomment-282465351, or mute the thread https://github.com/notifications/unsubscribe-auth/AOJm5mWF1AoAiAUSE7tetZAERrZ5JiK5ks5rf89AgaJpZM4ML5ZG .

DravitLochan commented 7 years ago

@opticod can you please see and tell me why travis is continuously failing me? :(

m-murad commented 7 years ago

@DravitLochan The error is No resource found that matches the given name (at 'text' with value '@string/button_next'). You haven't added the button text string to string.xml

DravitLochan commented 7 years ago

ohho. damn! just give me a sec

DravitLochan commented 7 years ago

@opticod please review and merge. Thank you for your support!

m-murad commented 7 years ago

@DravitLochan You might wanna squash the commits.

DravitLochan commented 7 years ago

done! @opticod @free4murad

DravitLochan commented 7 years ago

@free4murad @opticod :(

why does it want next to be a local variable instead?

opticod commented 7 years ago

@DravitLochan , we follow snake case for ids and camelCase for variable names. We will be updating the README section for easiness of contributors.

why does it want next to be a local variable instead?

If we doesn't require a variable globally, then we can limit the scope only where it is required. It helps to optimise function activation stacks calls by the program.

DravitLochan commented 7 years ago

@opticod no issues. I made the pr proper. please review and act :)

DravitLochan commented 7 years ago

@opticod did you review the pr after the changes?

opticod commented 7 years ago

@DravitLochan, you can go through 2c79128 , and see the changes that I made in addition to you.

DravitLochan commented 7 years ago

Oh thanks for the changes 😊

On 01-Mar-2017 2:16 PM, "Anupam Das" notifications@github.com wrote:

@opticod commented on this pull request.

@DravitLochan https://github.com/DravitLochan, I reviewed just now. There were some changes required that I added following your commit.

  1. Refactoring of your code was missing
  2. anim_bounceinup violates naming convention.
  3. next button should start with capital character.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/BuildmLearn/BuildmLearn-Toolkit-Android/pull/433#pullrequestreview-24425137, or mute the thread https://github.com/notifications/unsubscribe-auth/AOJm5tGcvy6WM62b8A4ZL9ZIsqgAVsDgks5rhTBrgaJpZM4ML5ZG .