BuiltBrokenModding / ICBM-Classic

Classic 1.6.4 version of ICBM remastered for newer MC versions

Other

44 stars 45 forks source link

Antimatter issues don't like OpenCubicChunks #333

Closed JAcamp1 closed 2 years ago

JAcamp1 commented 3 years ago

OpenCubicChunks allows building above and below build limits with the removal of the bedrock floor. The antimatter missile refuses to break anything above or below the limits while other missiles still are effective. Is there a config fix possibly?

clienthax commented 3 years ago

https://github.com/BuiltBrokenModding/ICBM-Classic/blob/6ec6ab695a0fadc4a6b14017c71dee042d43bb92/src/main/java/icbm/classic/content/blast/threaded/BlastAntimatter.java#L99 needs to be changed to grab from the current world settings i would guess

JAcamp1 commented 3 years ago

Makes sense. I'll make a recompile with the edit for my server settings for just server side.

JAcamp1 commented 3 years ago

334 may work may not compile properly. I'm not great at java.

clienthax commented 3 years ago

That's not the correct way to go about that, I will take a look later

DarkGuardsman commented 3 years ago

Have to also keep in mind some of this code is threaded and can't easily pull from the world data. So when making changes to pull from the world take care to make it thread safe.

clienthax commented 3 years ago

Made a PR for now, tested it, seems to work nicely