BuiltBrokenModding / MFFS_Classic

Classic version of Claclavia's MMFS mod
MIT License
19 stars 11 forks source link

[Bug] Fortron Capacitor deletes items on input #54

Closed JKohlman closed 1 year ago

JKohlman commented 1 year ago

Hi there,

I was playing around with the Interdiction Matrix and unfortunately discovered this rather bad bug, losing an entire inventory to it in the process.

Versions: Game 1.19.2 MFFS 5.0.0 Forge 43.2.14

The Fortron Capacitor will accept and permanently delete any item added to it's inventory via almost any means besides the player. This means that hoppers, an interdiction matrix item confiscation module, pipes, etc all push items successfully into the capacitor but they are gone and not dropped when it gets broken.

I'm not sure how it works with hoppers/pipes but as far as the interdiction matrix confiscation this simply checks if the nearby block has the capability ForgeCapabilities.ITEM_HANDLER and then inserts the item (see InventoryBlockEntity mergeIntoInventory).

To recreate it is as simple as placing a hopper into the capacitor and putting an item in.

image

Su5eD commented 1 year ago

Fixed in releases 1.20.1-5.1.5 and 1.19.2-5.0.1. Can you please confirm this?

JKohlman commented 1 year ago

That does seem to resolve the items getting deleted thank you very much!