Fix low_stock 1.7 new fields

Bukimedia / PrestaSharp

CSharp .Net client library for the PrestaShop API via web service

GNU General Public License v3.0

154 stars 152 forks source link

Fix low_stock 1.7 new fields #331

Closed OscarLate closed 5 years ago

OscarLate commented 6 years ago

This simple changes do this awesome library works fine in versions up 1.7 and lower. (I have more than 20 clients with this changes from 1.6.1.9 to 1.7.3 and tested for a two months )

mowcixo commented 5 years ago

Hi @OscarLate, thanks for the PR!

I think we should separate this PR in two:

One with the changes in both product and combination entities.
Other with the UTF-8 BOM fixings.

Remove the fixings in GenericFactory.cs as they are already merged in #299 and #330.

By the other hand, we shouldn't create a .sln file as it is a library with a single project, could you delete it from your PR?

mowcixo commented 5 years ago

Closing as it was merged in #339. The problem with UTF8 BOM will be archived until next related issue.