Async Task pattern added

Bukimedia / PrestaSharp

CSharp .Net client library for the PrestaShop API via web service

GNU General Public License v3.0

155 stars 151 forks source link

Async Task pattern added #344

Closed pumamood closed 5 years ago

pumamood commented 5 years ago

Hi, with some minimal change i added async pattern with Task.

let me know your thoughts.

mowcixo commented 5 years ago

Hello @pumamood, thanks for the PR!

We will study it because we want to release another things that refactor some code of your PR first, we will let you know soon!

mowcixo commented 5 years ago

Hello @pumamood, the refactors are made. Could you review the conflicts to merge this PR?

lgtm-com[bot] commented 5 years ago

This pull request fixes 1 alert when merging bf5492d3956d261e597f5df08359a7c63ca4ac89 into a1333baf9eb7fab5b0743298ced665ec6cb1a49b - view on LGTM.com

fixed alerts:

1 for String concatenation in loop

Comment posted by LGTM.com

pumamood commented 5 years ago

Hi @mowcixo everything updated and merged.

mowcixo commented 5 years ago

Hello @pumamood, thanks for your efforts.

I would like to separate functionalities in various PR, using this PR to just focus in async tasks, and the new things you wrote like image functionalities, refactorings etc... in new PRs each one. That would make them easier to review and the commit timeline would be more atomic.

Also, the changes you made in PrestaSharp.csproj should not be shared with the community.

Let me know if you agree :)

pumamood commented 5 years ago

yes, it was like that in my first commit but i worked on master branch for my project and i forgot to check it before last commit. I'm going to create a branch for it. let you know