search

Bukk94 / KickLib

C# library for accessing API from Kick.com livestreaming platform.
MIT License
16 stars 2 forks source link

Debug screenshot found in the nuget version of the library #9

Closed ElGauchooooo closed 4 months ago

ElGauchooooo commented 4 months ago

I was having a hard time figuring this one out. It looks like you've published a different version to nuget than the one that is being listed here on github.

In BrowserClient.SendRequestAsync(string url) you have an await page.ScreenshotAsync("D:/err.png"). Could you please remove this one and double check for other specialties, that are not being pushed to github? Thanks!

ElGauchooooo commented 4 months ago

image

ElGauchooooo commented 4 months ago

Ah looks like you've removed it on 0.1.9.

Bukk94 commented 4 months ago

Hi, this debug screenshot was included by mistake when package was compiled into new NuGet package and I didn't notice. Thanks for bringing that up. This code should be removed from 0.1.9.

I checked compiled package and version 0.1.9 doesn't contain any extra code. It matches master branch. In the future I would like to create CI/CD pipeline to release packages automatically without me needing to compile it myself.