search

Bulldog83 / JustMap

A minimap mod for Minecraft with Fabric launcher.
GNU General Public License v3.0
42 stars 17 forks source link

Retake on 1.17.1 support #105

Closed magicus closed 2 years ago

magicus commented 3 years ago

This is a retake on 1.17 support. I notice that in Bulldog83's original 1.17 branch, three changes were made at once:

To get the mod working, only bullet one needs to be done. Bullets two and three are certainly worthy goals, but it might make sense to do them separately. It is easy to end up in a mess where you don't know if your change is a real adaptation to 1.17, or just a rename refactoring due to changed mappings from yarn to Mojang.

So, what I did was to restart at the 1.16 master, keep the yarn mappings, use the fabric-provided gradle target to upgrade the code base automatically, and then make some manual adjustments that the automatic procedure could not handle. Most of these changes were trivial.

For rendering, some real changes has happened in 1.17 that needed adaptation. Still, I tied to keep as close to the original code as possible and only do the minimal amount of changes needed. I am no expert in GL/minecraft rendering, and much of the fixes here were stolen (err... "inspired"... :-)) by the changes done by Bulldog in his original branch.

At this point, the mod is working fine in 1.17.1. The only exception is grid lines, which I could not get working. (Also the lines around the dropdown menu are missing; something's apparently changed with line drawing.)

magicus commented 2 years ago

I've been playing with this for a while on 1.17. Seems to work fine. Technically, it should not really be merged into 1.16.2-master but I can't create a PR into a new branch.