Bulldog83 / JustMap

A minimap mod for Minecraft with Fabric launcher.
GNU General Public License v3.0
42 stars 17 forks source link

Fullscreen Map Panning #26

Closed HiJack-47 closed 4 years ago

HiJack-47 commented 4 years ago

It appears as though the speed of panning on the full screen map doesn't scale with the amount that the map is zoomed in. Pan speed should scale to make it easier to move larger distances on the map when zoomed out

Bulldog83 commented 4 years ago

Does it better now?

HiJack-47 commented 4 years ago

It doesn't appear to pan any faster when zoomed out. It also now only moves the map when you release the mouse as opposed to following it when zoomed all the way out

Bulldog83 commented 4 years ago

There is a problem here. With a large scale map dragging begins to lag. Therefore, I limited the number of the map updates per second. Prior to that, it depended on the scale: the larger the scale, the fewer updates. Now I tried to make a fixed delay. Apparently, it’s more optimal, after all, to return to dependence on the scale of the map.

HiJack-47 commented 4 years ago

I assumed it might be a problem with the fact that it has a lot of pixels/map elements to move all at once. The only thing i might suggest is finding a way of reducing the resolution as you zoom out to allow this to be less laggy, otherwise if there's no easy way to do it don't worry about it.

HiJack-47 commented 4 years ago

As of 1.0.48 Map panning only refreshes when you make an adjustment to the zoom level