search

Bunchhieng / hnreader

Open programming news with your favorite browser using command line
https://bunchhieng.github.io/hnreader/
MIT License
7 stars 10 forks source link

vendor folder needed? #18

Closed zpeters closed 5 years ago

zpeters commented 5 years ago

Did you intend to have the vendor folder under version control?

Bunchhieng commented 5 years ago

yeah. According to the doc, there is right or wrong to check in vendor folder. https://github.com/golang/dep/blob/master/docs/FAQ.md#should-i-commit-my-vendor-directory

The good thing is we don't need to run dep ensure to install the dependencies.