ISSUE#21: Browser name find for linux and windows

Bunchhieng / hnreader

Open programming news with your favorite browser using command line

https://bunchhieng.github.io/hnreader/

MIT License

7 stars 10 forks source link

ISSUE#21: Browser name find for linux and windows #25

Closed FrontSide closed 5 years ago

FrontSide commented 5 years ago

Browser names need to be converted from the normalized name given in the command line (e.g. "chrome") to a name that matches the associated executable on the operating system (e.g. "Google Chrome" on macos or "google-chrome" on linux).

This commit adds support of this function for windows and linux additionally to the existing support for macos (darwin).

Signed-off-by: FrontSide david@isan.engineer

Bunchhieng commented 5 years ago

Looks good. Nice refactoring the checkOs method.