search

Bunchhieng / hnreader

Open programming news with your favorite browser using command line
https://bunchhieng.github.io/hnreader/
MIT License
7 stars 10 forks source link

remove vendor folder in repo - use dep instead #47

Open mukeshmk opened 5 years ago

mukeshmk commented 5 years ago

Currently, the repo contains the vendor folder. Which need not be tracked by version control, as Gopkg.toml and Gopkg.lock files are used to track your dependencies. So please remove the vendor folder.

The vendor folder will be created with the same version of dependencies as specified in Gopkg.toml, upon running dep init.

mukeshmk commented 5 years ago

fixed it with the PR #48.

0xch4z commented 5 years ago

Just curious, why would you use dep over official go 1.11 modules? (see: https://github.com/golang/dep/issues/1959#issuecomment-407947097)

mukeshmk commented 5 years ago

I agree this info (in the below-mentioned link) is old, but it is still valid: This is the major difference as mentioned in the PR aka Doc-FAQ. There is a subtle difference in what you are trying to achieve, that would be the key difference.

https://github.com/golang/dep/issues/376

0xch4z commented 5 years ago

Right, but I'm not comparing dep to go get. I'm comparing it to go mod, which versions packages in a go.mod file and creates a go.sum file to summarize dependency installation for reproducible builds.

mukeshmk commented 5 years ago

Are we using go mod here? 🤔

0xch4z commented 5 years ago

No