search

Bunchhieng / hnreader

Open programming news with your favorite browser using command line
https://bunchhieng.github.io/hnreader/
MIT License
7 stars 10 forks source link

Vendor dependencies using dep #7

Closed plorefice closed 5 years ago

plorefice commented 5 years ago

This is a huge QoL improvement for new contributors who do not have to manually install all the required dependencies when checking out the repo. Plus it freezes the dependency versions, avoiding breaking changes.

PS: I also added to .gitignore the default executable name on Linux/macOS.

Bunchhieng commented 5 years ago

Thanks for the PR. Please ignore vendor folder in gitignore.

plorefice commented 5 years ago

Actually, the common practice is to not ignore the vendor folder, because newer Go versions will look in it first, then in GOPATH for dependencies. This way, you can clone and build without additional steps, and have all the dependencies in sync :)

As for the CI errors, I already have a PR ready that fixes those, when this will be merged.

On Tue, Oct 2, 2018, 19:39 Bun notifications@github.com wrote:

Thanks for the PR. Please ignore vendor folder in gitignore.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Bunchhieng/hnreader/pull/7#issuecomment-426364878, or mute the thread https://github.com/notifications/unsubscribe-auth/ABHO2kgQ2ozflw4XEpU4YwEO2p-BFlUwks5ug6TqgaJpZM4XEei8 .

Bunchhieng commented 5 years ago

Sounds good. Thanks for adding the vendor folder. Could you please fix the build failure?

plorefice commented 5 years ago

I pushed an update to the .travis.yml which:

This fixes the CI and build issues :)

Bunchhieng commented 5 years ago

Wonderful! Thanks for working on this. 👍