Bungie-net / api

Resources for the Bungie.net API
Other
1.22k stars 92 forks source link

Return private mode type for currentActivityModeTypes in getProfile #1020

Open mikechambers opened 5 years ago

mikechambers commented 5 years ago

Checking a users current status via

https://www.bungie.net/Platform/Destiny2/1/Profile/4611686018429783292/?components=204

and checking mode types with:

currentActivityModeTypes

When playing a private match currentActivityModeTypes does not include mode type 32 (PrivateMatchesAll), and thus there is no way to determine if the current activity is private (for example when playing a private crucible match).

When playing a private match of control, I am getting the following returned:

                    "currentActivityHash": 3897312654,
                    "currentActivityModeHash": 3199098480,
                    "currentActivityModeType": 10,
                    "currentActivityModeHashes": [
                        3199098480,
                        1164760504
                    ],
                    "currentActivityModeTypes": [
                        10,
                        5
                    ],

Can we get 32 to also be included in currentActivityModeTypes? (not sure if its a bug or an enhancement request)

vthornheart-bng commented 5 years ago

Ooh, I need to check on that - I imagine we can get that information, but I'll need to go digging!

vthornheart-bng commented 5 years ago

TFS 826360

I can't promise when I'll be able to get around to it, but it's in the backlog at least now.

mikechambers commented 5 years ago

Thanks!

mikechambers commented 5 years ago

@vthornheart-bng Can we also get PvPCompetitive / 64 enabled? (so we can detect when they are in a competitive game).

I can log a separate issue if needed.