search

Bungie-net / api

Resources for the Bungie.net API
Other
1.22k stars 92 forks source link

"Wrong" display name in PGCR for cross-save accounts #1036

Open joshhunt opened 5 years ago

joshhunt commented 5 years ago

If a cross-save enabled account plays on a platform other than their "home" platform (e.g. PS4-originating account plays on PC), the displayName for that player in the PGCR is "incorrect". By showing the membership info for the original platform, it will also show the displayName from that platform, rather than the displayName players saw in game.

An example is PGCR 4631908867 with player "Ali_Man_22". This game was played on PC, and the display name "Ali_Man_22" is from his PS4 Account. In-game, his display name was "GameXYZ".

I understand what/why this happens, but it can be confusing to see different display names in the PGCR than what was actually in the game. While i understand showing the battle-net displayName in this field might not be best, perhaps it could be in additional field like "inGameDisplayName"?

floatingatoll commented 5 years ago

If a Steam user changes their profile name after a match, which would you expect to see:

1) Their primary platform’s account name

2) The Steam account name they had at the time of the match?

3) The Steam account name they had at the time that the PGCR was generated and cached?

4) Their current Steam account name at the time that you fetch the PGCR?

On Sep 11, 2019, at 03:03, Josh Hunt notifications@github.com wrote:

 If a cross-save enabled account plays on a platform other than their "home" platform (e.g. PS4-originating account plays on PC), the displayName for that player in the PGCR is "incorrect". By showing the membership info for the original platform, it will also show the displayName from that platform, rather than the displayName players saw in game.

An example is PGCR 4631908867 with player "Ali_Man_22". This game was played on PC, and the display name "Ali_Man_22" is from his PS4 Account. In-game, his display name was "GameXYZ".

I understand what/why this happens, but it can be confusing to see different display names in the PGCR than what was actually in the game. While i understand showing the battle-net displayName in this field might not be best, perhaps it could be in additional field like "inGameDisplayName"?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

joshhunt commented 5 years ago

(keeping in mind that all platforms - Xbox, PSN, Steam, Battle.net allows for name changes, just at varying frequencies)

2 or 3 seems like the 'most correct' and consistent. It's always been my understanding that PGCRs are a snapshot of the game, and you should be able to recreate the in-game post game carnage report screen using the API.

vthornheart-bng commented 5 years ago

I'm going to need to look into it - I'm unsure if I'll ever be able to provide (2) or (3), it depends on what the stats backend is saving off. I may be able to fetch (4), but I think that will partly be dependent on fixing the (still pending) bug where the platform's not coming back correctly.

vthornheart-bng commented 5 years ago

I'm going to lump this in with the wrong platform in PGCR bug.

joshhunt commented 5 years ago

4 makes just as much practical sense.

On Thu, 12 Sep 2019 at 6:28 pm, Vendal Thornheart notifications@github.com wrote:

I'm going to lump this in with the wrong platform in PGCR bug.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Bungie-net/api/issues/1036?email_source=notifications&email_token=AAALIPRPEXT4FYE7NWGKKCLQJJ35JA5CNFSM4IVR4INKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6SUR6Y#issuecomment-530925819, or mute the thread https://github.com/notifications/unsubscribe-auth/AAALIPREHPRAB4E4KVOPXPTQJJ35JANCNFSM4IVR4INA .