search

Bungie-net / api

Resources for the Bungie.net API
Other
1.22k stars 92 forks source link

Access to Scopes for Message endpoints? #1042

Open soren42 opened 5 years ago

soren42 commented 5 years ago

Is there any chance that (in the near-ish future) that we'll be able to have access to the /Message/ endpoints for sending BungieNet messages from our applications?

(FYI, my specific use case is a little something like this: I have activity requirements for members of my clans — let's say, complete some in-game activity every 30 days… just so we can keep recruiting active players. When a member is approaching 30 days without playing D2 — say on idle day 25 — I'd love to be able to have my automated clan admin dashboard send them a BungieNet direct message from me warning them that they're close to being kicked. This is preferable to just booting them from the clan, which is what the tool does currently. In the past, this was feasible to do by hand, however, as we've grown, there's just too much turnover and too many clans to expect this to remain something that is manually discharged.)

vthornheart-bng commented 4 years ago

I'll bring it up - however, we've had problems with people using the Messaging system to spam folks in the past, which makes me hesitant to open the use of it up. We'll have to consider the implications. There'd definitely be some benefits of opening it up as well from this same perspective, potentially. It at least would make "good agents" able to be contacted. But I need to discuss it further before I say whether we can give a thumbs up to it.

floatingatoll commented 4 years ago

OP, would the messages always be sent from a clan admin to a clan member in that same clan?

On Sep 18, 2019, at 10:18, Vendal Thornheart notifications@github.com wrote:

 I'll bring it up - however, we've had problems with people using the Messaging system to spam folks in the past, which makes me hesitant to open the use of it up. We'll have to consider the implications. There'd definitely be some benefits of opening it up as well from this perspective, potentially.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

rraziel commented 4 years ago

Not trying to hijack this issue, but being able to:

  1. create fireteams (so far it seems everything is read-only) and
  2. invite people who have joined said fireteam

Would be very nice as well.

I assume the requirements - the user needs to have joined the fireteam before receiving an invite - should prevent any misuse, but this wouldn't be the first time I underestimate how evil people can be...

soren42 commented 4 years ago

OP, would the messages always be sent from a clan admin to a clan member in that same clan?

@floatingatoll Yes, at least in my use case — and I believe that would help limit the spam potential.

floatingatoll commented 4 years ago

Fireteam joins are off limits for the API as previously discussed every year or so. Search older, closed, issues for Discord integration and Fireteams for more details.

On Sep 18, 2019, at 16:13, Raziel notifications@github.com wrote:

 Not trying to hijack this issue, but being able to:

create fireteams (so far it seems everything is read-only) and invite people who have joined said fireteam Would be very nice as well. I assume the requirements - the user needs to have joined the fireteam before receiving an invite - should prevent any misuse, but this wouldn't be the first time I underestimate how evil people can be...

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

rraziel commented 4 years ago

Ah my bad, wasn't aware of those discussions.

rraziel commented 4 years ago

Just to be sure I get you right though - eg wrt #955 which seems to say there is some work in progress - when you say off limits you mean never going to happen or just not happening in the foreseeable future?

vthornheart-bng commented 4 years ago

I've given it some further consideration, and I think that the big problem for us isn't actually the security but rather that our resources are already stretched thin on Bungie.net. Endpoints that we make publicly available become endpoints that we have to provide support for and guarantee some degree of backwards compatibility and uptime for in the future. I think given how little time we can allocate even to the Destiny API at the moment, extending that official support to other systems would likely be a bad idea. (also, these messaging endpoints were definitely never built with external user convenience in mind... if we did get the time to support it publicly, I'd like for it to come with some refactoring for user convenience)

I'm going to say that we can't do it for now, but if we end up in the future with enough people on our team to give the API the attention and support it deserves, I'd put this on the list of features I'd like to provide official support for. So let's put it on the future wishlist, and I'll try to remember this should we end up in that ideal future.