search

Bungie-net / api

Resources for the Bungie.net API
Other
1.22k stars 92 forks source link

SearchDestinyPlayer for cross save accounts returning displayName/membershipType for primary account #1055

Open v-fedorov opened 4 years ago

v-fedorov commented 4 years ago

ex: searching steam name Platform/Destiny2/SearchDestinyPlayer/3/joel.jib/ returns

{"iconPath":"\/img\/theme\/destiny\/icons\/icon_steam.png","crossSaveOverride":0,"isPublic":false,"membershipType":1,"membershipId":"4611686018429588688","displayName":"Cheese Monkey"}

Which is that players override account on xbox and not having the steam name there makes it really confusing

floatingatoll commented 4 years ago

Is searching by name valid for platform Steam at all? I’m a bit surprised it doesn’t return 403 Forbidden.

On Oct 2, 2019, at 17:18, Vlad notifications@github.com wrote:

 ex: searching steam name Platform/Destiny2/SearchDestinyPlayer/3/joel.jib/ returns

{"iconPath":"\/img\/theme\/destiny\/icons\/icon_steam.png","crossSaveOverride":0,"isPublic":false,"membershipType":1,"membershipId":"4611686018429588688","displayName":"Cheese Monkey"} Which is that players override account on xbox and not having the steam name there makes it really confusing

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

floatingatoll commented 4 years ago

Never mind, I see it returns current Steam results! Nifty.

On Oct 2, 2019, at 18:44, Rowan Green rowan@pobox.com wrote:

 Is searching by name valid for platform Steam at all? I’m a bit surprised it doesn’t return 403 Forbidden.

On Oct 2, 2019, at 17:18, Vlad notifications@github.com wrote:

 ex: searching steam name Platform/Destiny2/SearchDestinyPlayer/3/joel.jib/ returns

{"iconPath":"\/img\/theme\/destiny\/icons\/icon_steam.png","crossSaveOverride":0,"isPublic":false,"membershipType":1,"membershipId":"4611686018429588688","displayName":"Cheese Monkey"} Which is that players override account on xbox and not having the steam name there makes it really confusing

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

vthornheart-bng commented 4 years ago

I'll need to give this one some thought. We have competing priorities that result in the results you're getting there, but I would like to give a better experience when searching for cross save users. I'll add a bug so that I can loop back to this.

vthornheart-bng commented 4 years ago

TFS 838478