search

Bungie-net / api

Resources for the Bungie.net API
Other
1.22k stars 92 forks source link

Chrome warning for cross-domain cookies #1066

Open rraziel opened 5 years ago

rraziel commented 5 years ago

Chrome recently started issuing warning regarding the cookies set by the Bungie platform:

A cookie associated with a cross-site resource at http://www.bungie.net/ was set without the SameSite attribute. A future release of Chrome will only deliver cookies with cross-site requests if they are set with SameSite=None and Secure. You can review cookies in developer tools under Application>Storage>Cookies and see more details at https://www.chromestatus.com/feature/5088147346030592 and https://www.chromestatus.com/feature/5633521622188032.

vthornheart-bng commented 5 years ago

Thank you! We'll take a look at that!

vthornheart-bng commented 5 years ago

TFS 837872

floatingatoll commented 5 years ago

https://blog.chromium.org/2019/10/developers-get-ready-for-new.html

On Oct 4, 2019, at 13:35, Raziel notifications@github.com wrote:

 Chrome recently started issuing warning regarding the cookies set by the Bungie platform:

A cookie associated with a cross-site resource at http://www.bungie.net/ was set without the SameSite attribute. A future release of Chrome will only deliver cookies with cross-site requests if they are set with SameSite=None and Secure. You can review cookies in developer tools under Application>Storage>Cookies and see more details at https://www.chromestatus.com/feature/5088147346030592 and https://www.chromestatus.com/feature/5633521622188032.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

Tetron-bng commented 5 years ago

Bungie.net uses cookies in the 3P cases sparingly, mainly for performance improvements around caching (at least that is how my memory serves). Will anything break if a client does not honor cookies being set by Bungie.net?

vthornheart-bng commented 5 years ago

Indeed, I believe the only one that will actually matter is the affinitization cookie. I'm asking around about that now, to see if we can change it!