search

Bungie-net / api

Resources for the Bungie.net API
Other
1.21k stars 92 forks source link

[spec] activity list is nullable, currentpage is a query parameter #1240

Open archived-2f4dd0 opened 4 years ago

archived-2f4dd0 commented 4 years ago

Destiny.HistoricalStats.DestinyActivityHistoryResults.activities is nullable. instead of containing an empty array, it'll be completely missing if there's no activities to report.

as reported here, https://github.com/DestinyItemManager/bungie-api-ts/issues/2 GetMembersOfGroup GetAdminsAndFounderOfGroup GetBannedMembersOfGroup GetPendingMemberships GetInvitedIndividuals list currentpage as a path parameter, but i am pretty sure it's actually a query parameter.

actually, the latter is partially a duplicate of https://github.com/Bungie-net/api/pull/192 / https://github.com/Bungie-net/api/issues/124

archived-2f4dd0 commented 4 years ago

bonus: putting the stats.bungie.net requirement in the comments for GetPostGameCarnageReport would be cool

archived-2f4dd0 commented 4 years ago

some other nullable things: UserInfoCard.applicableMembershipTypes UserInfoCard.supplementalDisplayName DestinyInventoryItemDefinition.quality