Bungie-net / api

Resources for the Bungie.net API
Other
1.22k stars 92 forks source link

DestinyActivityModeType that includes public and private crucible matches #1302

Open mikechambers opened 3 years ago

mikechambers commented 3 years ago

Request to create a DestinyActivityModeType that includes all pvp matches, public and private. It could be named AllPvPWithPrivate.

Currently, in order to pull ALL pvp matches (public and private), you must make two API calls to GetActivityHistory.

https://bungie-net.github.io/multi/operation_get_Destiny2-GetActivityHistory.html#operation_get_Destiny2-GetActivityHistory

This is because private matches are not included in AllPvP. Instead you must make two calls, one for AllPvP and one for PrivateMatchesAll.

This complicates working with all matches, requires additional API calls, and puts additional strain on the API server.

This is related to #1301

floatingatoll commented 3 years ago

Do these two API calls contain data that is not present in the PGCR records themselves? Or do they return exclusively a list of PGCR IDs and nothing else of value to you.

mikechambers commented 3 years ago

I am using the API calls to:

  1. Get summary data for the member / character for all pvp activities (public and private), including their performance in the match and a list of all of their PVP activities.
  2. To get the ids for the PGCR to get more detailed match info (weapons, medals) (if the user chooses to view it).

Including a screenshot of Redrix. All of the match data displayed there is from a single call to GetActivityHistory (will be two calls once we support private matches, and thus this feature request). If the user clicks an activity, we then retrieve the PGCR and show complete match details (for all players).

Screen Shot 2020-09-20 at 11 34 13 AM
Marruk commented 3 years ago

I would love this as well!

My goal is to show a chronological list of PVP matches of a player, both public and private. Needing six calls to achieve that goal (two per character) is not really worth it for me at the moment.