search

Bungie-net / api

Resources for the Bungie.net API
Other
1.22k stars 92 forks source link

classType wrong for universal ornaments #1553

Open nev-r opened 3 years ago

nev-r commented 3 years ago

i thought this was effectively a bump of josh's 2017 issue here: https://github.com/Bungie-net/api/issues/345 but it actually turns out the example he provided has since been fixed: 1397648181

however, several seasons of eververse universal ornament armor that i spot checked, have the wrong classType for example 1375679173 and 20109006

these items' itemTypeDisplayName, itemTypeAndTierDisplayName, and plugCategoryIdentifier all seem aware that the items are class specific, so maybe the classType heuristics can be adjusted? thanks.

nev-r commented 3 years ago

same goes for class-specific finishers: https://data.destinysets.com/i/InventoryItem:3441162174

itemTypeDisplayName, itemTypeAndTierDisplayName, and stackUniqueLabel are aware it's class-specific, classType isn't