Regarding the primary `mode` on "Team Quickplay" and "Competitive" PGCRs

[justrealmilk]

Currently, matches played in these playlists have a mode which corresponds with the specific Crucible activity type. Unfortunately, this value is how the most important endpoint, Destiny2.GetActivityHistory, works (for the majority who can't run PGCR scrape farms!) to filter a player's activity history by.

Without setting the primary mode to the playlist mode, there's no way to distinguish between, for example, a friendly Rift game and a competitive Rift game.

So, if a dev builds a system based around DestinyActivityModeType, they end up in an awkward situation:

Without changes, it's now extremely difficult to see only "Team Quickplay" or "Competitive" activity history as it mixed in with other types of games.

[mikechambers]

Just for reference, this completely breaks the ability to view competitive matches in Redrix, as well as DARCI and dcli.

Specifically this call:

https://stats.bungie.net/Platform/Destiny2/1/Account/4611686018429783292/Character/2305843009264966985/Stats/Activities/?mode=69

Should return all PvpCompetitive games for Rift, Survival and Showdown. Currently it only returns survival matches (almost certainly related to other mode bugs logged).

[jshaffstall-bng]

Sorry for the delay on these Competitive Crucible game history issues. The good news is that this should be a Bungie.net-only fix that applies retroactively, and we plan to ship in tomorrow (Friday) morning.

[mikechambers]

@jshaffstall-bng Any update on these? All of the comp issues don't appear to have been fixed yet. (i.e. wrong / missing mode data, no team data, etc...).

Here are comp specific mode issues: #1751 #1743 #1740 #1739

There is also a similar PrivateMatches issue: #1749

Finally, there are a number of comp related manifest issues: #1746 #1741

[justrealmilk]

For me, no rush if all the reports get regenerated 🤷🏼