Bungie-net / api

Resources for the Bungie.net API
Other
1.22k stars 92 forks source link

Honor Platform Online Status #313

Open xlxCLUxlx opened 6 years ago

xlxCLUxlx commented 6 years ago

Looks like when you return GroupsV2.GroupMember the isOnline flag is using Bungie's indicated value of whether the user is online or not and ignores the platform. For example, if a user chooses to appear to be offline on say Blizzard but still play and you call the GroupV2.GetMembersOfGroup endpoint it will show that user as being online playing when in reality they want to be anonymous. It would be nice to honor the plarform as maybe an enhancement.

floatingatoll commented 6 years ago

Does Destiny 2 (in-game) honor the Blizzard "offline" switch when showing friends/clanmates?

On Tue, Nov 21, 2017 at 11:00 AM, Eric notifications@github.com wrote:

Looks like when you return GroupsV2.GroupMember https://bungie-net.github.io/multi/schema_GroupsV2-GroupMember.html#schema_GroupsV2-GroupMember the isOnline flag is using Bungie's indicated value of whether the user is online or not and ignores the platform. For example, if a user chooses to appear to be offline on say Blizzard but still play and you call the GroupV2.GetMembersOfGroup https://bungie-net.github.io/multi/operation_get_GroupV2-GetMembersOfGroup.html#operation_get_GroupV2-GetMembersOfGroup endpoint it will show that user as being online playing when in reality they want to be anonymous. it would be nice to honor the plarform as maybe an enhancement.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Bungie-net/api/issues/313, or mute the thread https://github.com/notifications/unsubscribe-auth/AAFqDAXqOl38Zozp55fT0PHa73HTFhO1ks5s4x3NgaJpZM4QmVLu .

vthornheart-bng commented 6 years ago

Hmm, good points and questions. I'll have to do a little investigating, and talk to the relevant designer once they are back from Thanksgiving vacation. Let's loop back to this after that.

xlxCLUxlx commented 6 years ago

Just a quick follow-up with a little more information on what I am seeing (I did testing against XBox since that's where my friends play and I am lone wolf on PC).

In game when going to the clan page if a user has set their profile to appear offline then the clan page does NOT display them as being online even if they are playing which is what is expected.

The mobile app; however, will show the player as being online under the Clan Roster and Online section of the clan which is unexpected. Under your friends section though of the app they will appear offline which is expected. I have noticed the same thing in the web (presumably since mobile and web are hitting the API and using the isOnline flag and in game has other code).

Thanks!

floatingatoll commented 5 years ago

Can this be assigned a TFS? If it’s a valid issue, then it may need to be addressed sooner than wishlist due to Blizzard privacy agreements or so forth.

vthornheart-bng commented 5 years ago

Ah, glad you looped back to this - indeed, we need to get this on our backlog. I'll get it in there on Monday.

charlie4372 commented 5 years ago

Did anything ever happen with this?

vthornheart-bng commented 5 years ago

Unfortunately not - I'm bringing it back up with folks now, but I'm uncertain whether we will be able to provide this change.

However, there is a potential false sense of security that users should know about if we are able to change how this status flag is populated. Users will still be able to tell if you have been online by - for example but not limited to - digging through PGCRs looking for games you played in. We will not be removing people from PGCR or other related data, as accessibility to this info is vital for player abuse reports and other important features. You could also be discovered through even more surreptitious means, such as someone watching who you play with frequently, and looking for streaming videos where you or your friends have played for example. We cannot promise absolute anonymity of online presence when playing Destiny.

ckhicks commented 5 years ago

It's sort of related to this new component, ya? Seems like similar activity that would be accessible and/or expected through that functionality. Always a trade-off between features and privacy. :D

vthornheart-bng commented 5 years ago

Indeed - or even the information we return about when you last played could be used to infer this kind of information if someone wanted to.

xlxCLUxlx commented 5 years ago

Hi Guys,

When I had created this the intent was not for total anonymity within Destiny because as you point out people could still dig through PGCR's, etc. and I would not expect you to try and remove information based on someones setting. I think the original intent was more if someone feels like playing solo and doesn't want to appear online at the moment they are playing then don't show them online via the flag which would hide them in the official mobile app and third party offerings.

Regards!

floatingatoll commented 5 years ago

I second the prior comment here; it’s impossible to hide from inferences if your profile is public and that’s fine - it simply would be nice if you didn’t show up as Online in friends list when your platform is set to Invisible or equivalent.

On Aug 23, 2019, at 14:11, Eric notifications@github.com wrote:

Hi Guys,

When I had created this the intent was not for total anonymity within Destiny because as you point out people could still dig through PGCR's, etc. and I would not expect you to try and remove information based on someones setting. I think the original intent was more if someone feels like playing solo and doesn't want to appear online at the moment they are playing then don't show them online via the flag which would hide them in the official mobile app and third party offerings.

Regards!

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

vthornheart-bng commented 5 years ago

Totally understandable - as long as everyone understands the caveats that come with it (the fact that there can't be total anonymity) then I'm definitely in support of it!

I still can't promise that we can get at that data such that we can do that filtering, investigation will need to be conducted. But I'll loop back on this once I hear from Triage.