search

Bungie-net / api

Resources for the Bungie.net API
Other
1.22k stars 92 forks source link

VendorDefinition "displayProperties" bug #333

Closed lowlines closed 3 weeks ago

lowlines commented 6 years ago

Just noticed that in the mobile manifest, the VendorDefinition appears to double output "displayProperties" like so...

"displayProperties": {
        "subtitle": "",
        "originalIcon": "/common/destiny2_content/icons/c369b9dc3e49a914e21a8500443308e2.jpg",
        "requirementsDisplay": [],
        "description": "Weapon Ornaments used to alter the appearance of your gear and found only in the Bright Engram.",
        "name": "Ornaments",
        "icon": "/common/destiny2_content/icons/c369b9dc3e49a914e21a8500443308e2.jpg",
        "hasIcon": true
    },
    "BungieNet.Engine.Contract.Destiny.World.Definitions.IDestinyDisplayDefinition.displayProperties": {
        "subtitle": "",
        "originalIcon": "/common/destiny2_content/icons/c369b9dc3e49a914e21a8500443308e2.jpg",
        "requirementsDisplay": [],
        "description": "Weapon Ornaments used to alter the appearance of your gear and found only in the Bright Engram.",
        "name": "Ornaments",
        "icon": "/common/destiny2_content/icons/c369b9dc3e49a914e21a8500443308e2.jpg",
        "hasIcon": true
    },
vthornheart-bng commented 6 years ago

Ah, aye - I think we have another bug on this, but I haven't gotten around to cleaning it up. This appears to be an unfortunate side effect of a funky interface design decision on my part combined with how we're serializing this data... I need to look into how to remove those.